korowa commented on code in PR #11627:
URL: https://github.com/apache/datafusion/pull/11627#discussion_r1698965692
##########
datafusion/expr/src/groups_accumulator.rs:
##########
@@ -158,6 +158,24 @@ pub trait GroupsAccumulator: Send {
total_num_groups: usize,
) -> Result<()>;
+ /// Converts input batch to intermediate aggregate state,
+ /// without grouping (each input row considered as a separate
+ /// group).
+ fn convert_to_state(
+ &self,
+ _values: &[ArrayRef],
+ _opt_filter: Option<&BooleanArray>,
+ ) -> Result<Vec<ArrayRef>> {
+ not_impl_err!("Input batch conversion to state not implemented")
+ }
+
+ /// Returns `true` is groups accumulator supports input batch
+ /// to intermediate aggregate state conversion (`convert_to_state`
+ /// method is implemented).
+ fn convert_to_state_supported(&self) -> bool {
Review Comment:
Took the naming from `groups_accumulator_supported`, but naming pattern that
you suggest seems to be used more widely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
