Rachelint commented on PR #11750: URL: https://github.com/apache/datafusion/pull/11750#issuecomment-2260899751
> > Seems duckdb has the similar check(but just use the u16 prefix), maybe we can mention? > > https://github.com/duckdb/duckdb/blob/f92559f42c118075baaa8daafc437954eb5c85ec/src/execution/aggregate_hashtable.cpp#L379-L386 > > The linked PR is interesting: [duckdb/duckdb#9575](https://github.com/duckdb/duckdb/pull/9575) Interesting, it seems the common point with #11718 is that we should consider the increasing collision when the hash table is filling up. > > maybe we can mention? > > I am not sure what we would mention 🤔 Maybe can you propose the wording ? > > Or maybe we can leave a comment to the duckdb art in one of the comments on #11718 ? Maybe better to leave a comment, seems actually hard to make a good conclusion about the discussion in #11718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
