kumarUjjawal commented on code in PR #22508:
URL: https://github.com/apache/datafusion/pull/22508#discussion_r3300974553
##########
datafusion/functions-nested/src/remove.rs:
##########
@@ -512,30 +521,47 @@ mod tests {
fn test_array_remove_n_nullability() {
for nullability in [true, false] {
for item_nullability in [true, false] {
- let input_field = Arc::new(Field::new(
- "num",
- DataType::new_list(DataType::Int32, item_nullability),
- nullability,
- ));
- let args_fields = vec![
- Arc::clone(&input_field),
- Arc::new(Field::new("a", DataType::Int32, false)),
- Arc::new(Field::new("b", DataType::Int64, false)),
- ];
- let scalar_args = vec![
- None,
- Some(&ScalarValue::Int32(Some(1))),
- Some(&ScalarValue::Int64(Some(1))),
- ];
-
- let result = ArrayRemoveN::new()
- .return_field_from_args(ReturnFieldArgs {
- arg_fields: &args_fields,
- scalar_arguments: &scalar_args,
- })
- .unwrap();
-
- assert_eq!(result, input_field);
+ for element_nullability in [true, false] {
+ for count_nullability in [true, false] {
Review Comment:
Neat idea, but I think for the sake of readability by other maintainers we
should stick with nested loops.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
