akmhatey-ai commented on PR #22276: URL: https://github.com/apache/datafusion/pull/22276#issuecomment-4508800569
Updated in 48152f089. Covered the other negative-input cases from your example: - `log` now rejects negative values for float and decimal inputs. - `log2` and `log10` now use checked unary handling for negative Float32/Float64 inputs. - Invalid bases are unchanged and still follow the existing `NaN` behavior. Validation run: - `cargo test -p datafusion-functions test_log -- --nocapture` - `cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar:640` - `cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar:662` - `cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar:711` - `cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar:722` - `cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar:750` - `cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar:761` - `rustfmt --check datafusion/functions/src/math/log.rs datafusion/functions/src/macros.rs datafusion/functions/src/math/mod.rs` - `git diff --check` - `gitleaks detect --no-git` on the changed files One limitation: full `cargo test -p datafusion-sqllogictest --test sqllogictests -- scalar` still fails later on existing `aggregate_test_100` expectations around lines 1551-1600, outside this log change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
