timsaucer commented on code in PR #1545:
URL:
https://github.com/apache/datafusion-python/pull/1545#discussion_r3275416051
##########
crates/core/src/codec.rs:
##########
@@ -642,6 +710,186 @@ fn cloudpickle<'py>(py: Python<'py>) ->
PyResult<Bound<'py, PyAny>> {
.map(|cached| cached.bind(py).clone())
}
+//
=============================================================================
+// Shared Python window UDF encode / decode helpers
+//
+// Cloudpickle tuple shape: `(name, evaluator_factory, input_schema_bytes,
+// return_schema_bytes, volatility_str)`. The evaluator factory is the
+// Python callable that produces a new evaluator instance per partition.
+//
=============================================================================
+
+pub(crate) fn try_encode_python_window_udf(node: &WindowUDF, buf: &mut
Vec<u8>) -> Result<bool> {
Review Comment:
Yes. Some were based on hand written code and some the agent generated
mostly from scratch. Then I didn't care enough to make the naming consistent,
but I'll update it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
