gabotechs commented on code in PR #21193:
URL: https://github.com/apache/datafusion/pull/21193#discussion_r3263942599
##########
datafusion/substrait/src/extensions.rs:
##########
@@ -27,7 +27,7 @@ use
substrait::proto::extensions::simple_extension_declaration::{
/// types. This structs facilitates the use of these extensions in DataFusion.
/// TODO: DF doesn't yet use extensions for type variations
<https://github.com/apache/datafusion/issues/11544>
/// TODO: DF doesn't yet provide valid extensionUris
<https://github.com/apache/datafusion/issues/11545>
-#[derive(Default, Debug, PartialEq)]
+#[derive(Clone, Default, Debug, PartialEq)]
Review Comment:
It's better to not implement `Clone` here, that opens the door to mistakes
where there are multiple desynchronized copies of `Extensions`, and I also see
that it's not really needed for this PR, maybe this is an artifact of a
previous iteration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
