andygrove opened a new pull request, #4362: URL: https://github.com/apache/datafusion-comet/pull/4362
## Which issue does this PR close? Part of #4020. ## Rationale for this change Companion docs update to #4019. Once `native_iceberg_compat` is removed and Comet has a single Parquet scan implementation, references to the two named impls (`native_datafusion`, `native_iceberg_compat`) and the `spark.comet.scan.impl` selection mechanic become misleading. This PR strips those references from the user guide and contributor guide so the docs match the post-#4019 reality. This PR is held as a draft until #4019 is merged. ## What changes are included in this PR? - `compatibility/scans.md`: flattened to a single "Parquet Scan Limitations" section; impl comparison table and `spark.comet.scan.impl` paragraph removed; shared + `native_datafusion` limitations merged; `native_iceberg_compat` limitation dropped. - `compatibility/spark-versions.md`: per-version notes now refer to "Comet's Parquet scan"; anchor links retargeted to `#parquet-scan-limitations`. - `compatibility/index.md`: dropped the "(both scan implementations, …)" parenthetical. - `user-guide/latest/datasources.md`: S3 section rephrased for a single scan; `--conf spark.comet.scan.impl=native_datafusion` removed from the HDFS example and the two S3 examples; the HDFS Scala snippet's `COMET_NATIVE_SCAN_IMPL` line removed. - `user-guide/latest/understanding-comet-plans.md`: removed the "active scan implementation is shown in brackets" note from `CometScan`. - `contributor-guide/adding_a_new_spark_version.md`: dropped `scan_impl: "auto"` guidance, removed `spark_sql_test_native_iceberg_compat.yml`, dropped `scan-impl` from the matrix list. - `contributor-guide/bug_triage.md`: removed the two impl labels from the area-label list and reworded the "core path over experimental" principle. Changelog and versioned-snapshot files under `docs/source/changelog/` and `docs/comet-0.16/` are intentionally untouched. ## How are these changes tested? Docs-only change. Verified that no active docs file under `docs/source/` (excluding `changelog/`) references `native_datafusion`, `native_iceberg_compat`, `spark.comet.scan.impl`, `COMET_NATIVE_SCAN_IMPL`, or `SCAN_NATIVE_DATAFUSION`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
