wirybeaver opened a new pull request, #1727:
URL: https://github.com/apache/datafusion-ballista/pull/1727
Pure-logic atomic counter that aggregates per-stage row counts and fires a
one-shot CancelRemaining decision when the running sum crosses limit *
safety_factor. Foundation for the AQE early-stop feature (#1359): subsequent
commits add the plan-time eligibility analyzer, scheduler-side wiring into
update_task_statuses, and an EarlyStopCancel event that finalizes the job as
Successful with partial output.
Trigger uses AtomicU64 fetch_add (Relaxed) for row accumulation and
AtomicBool swap (SeqCst) on the triggered flag so that, across racing
observers, exactly one CancelRemaining is returned. Threshold is computed in
fixed-point arithmetic to avoid f64 imprecision at large limits.
The observe() path carries an asymmetric correctness invariant: we must fire
no earlier than sum >= limit (firing early would cause the downstream LimitExec
to under-report). Firing late is always safe; it only wastes I/O.
Includes 9 unit tests covering threshold rounding, below/at/above trigger
transitions, single-fire guarantee, untagged-stage handling, multi-stage
aggregation, 32-thread concurrent observer race, and constructor preconditions.
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
