Sean-Kenneth-Doherty commented on PR #22280:
URL: https://github.com/apache/datafusion/pull/22280#issuecomment-4468383517
Follow-up pushed after final local review: the arithmetic now wraps in
nanoseconds before reducing back to the time unit, which covers negative
sub-second intervals for lower-precision time values.
Added regression:
- `arrow_cast('00:00:00', 'Time32(Second)') - interval '500 milliseconds'`
-> `23:59:59`
Reran validation after the follow-up:
- `TMPDIR=/home/sean/.cache/codex-tmp
CARGO_TARGET_DIR=/home/sean/.cache/codex-cargo-targets/datafusion-time-interval
RUSTFLAGS='-Cdebuginfo=0' cargo test -p datafusion-sqllogictest --test
sqllogictests -- arith_time_interval`
- `cargo fmt --all --check`
- `git diff --check`
- `TMPDIR=/home/sean/.cache/codex-tmp
CARGO_TARGET_DIR=/home/sean/.cache/codex-cargo-targets/datafusion-time-interval
RUSTFLAGS='-Cdebuginfo=0' cargo clippy -p datafusion-physical-expr -p
datafusion-expr-common --all-targets --all-features -- -D warnings`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
