huaxingao commented on code in PR #733:
URL: https://github.com/apache/datafusion-comet/pull/733#discussion_r1693980607
##########
spark/src/test/scala/org/apache/comet/exec/CometExecSuite.scala:
##########
@@ -63,23 +63,35 @@ class CometExecSuite extends CometTestBase {
}
}
- test("Window range frame should fall back to Spark") {
+ test("Window range frame with Long") {
val df =
Seq((1L, "1"), (1L, "1"), (2147483650L, "1"), (3L, "2"), (2L, "1"),
(2147483650L, "2"))
.toDF("key", "value")
checkAnswer(
df.select(
$"key",
- count("key").over(
+ sum("key").over(
Review Comment:
We currently don't support `count` so change to `sum`. Previously, even if
the aggregate function is not supported, it still goes to the window frame
code. In this PR, I return None directly if aggregate function is not
supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
