viirya commented on code in PR #733:
URL: https://github.com/apache/datafusion-comet/pull/733#discussion_r1693784042
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -275,12 +284,20 @@ object QueryPlanSerde extends Logging with
ShimQueryPlanSerde with CometExprShim
.setCurrentRow(OperatorOuterClass.CurrentRow.newBuilder().build())
.build()
case e =>
+ val offset = e.eval() match {
+ case i: Integer => i.toLong
+ case l: Long => l
+ case _ =>
+ throw new IllegalArgumentException(
+ "Unsupported data type for window function row/range offset")
Review Comment:
You will fail the query directly instead of falling back to Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
