timsaucer commented on issue #767:
URL: 
https://github.com/apache/datafusion-python/issues/767#issuecomment-2253478528

   No, but I did write a small script to check and this is what I see missing:
   
   ```
   attribute,datafusion,Catalog,
   attribute,datafusion,Database,
   attribute,datafusion,ExecutionPlan,
   attribute,datafusion,LogicalPlan,
   attribute,datafusion,RecordBatch,
   attribute,datafusion,RecordBatchStream,
   attribute,datafusion,Table,
   value,datafusion,__all__,runtime
   value,datafusion,__all__,Catalog
   value,datafusion,__all__,Database
   value,datafusion,__all__,Table
   value,datafusion,__all__,AggregateUDF
   value,datafusion,__all__,LogicalPlan
   value,datafusion,__all__,ExecutionPlan
   value,datafusion,__all__,RecordBatch
   value,datafusion,__all__,RecordBatchStream
   value,datafusion,__all__,common
   value,datafusion,__all__,expr
   value,datafusion,__all__,functions
   value,datafusion,__all__,object_store
   value,datafusion,__all__,substrait
   attribute,datafusion.common,DFSchema,
   attribute,datafusion.common,DataType,
   attribute,datafusion.common,DataTypeMap,
   attribute,datafusion.common,NullTreatment,
   attribute,datafusion.common,PythonType,
   attribute,datafusion.common,RexType,
   attribute,datafusion.common,SqlFunction,
   attribute,datafusion.common,SqlSchema,
   attribute,datafusion.common,SqlStatistics,
   attribute,datafusion.common,SqlTable,
   attribute,datafusion.common,SqlType,
   attribute,datafusion.common,SqlView,
   attribute,datafusion.common,__all__,
   attribute,datafusion.expr,EmptyRelation,
   attribute,Expr,__radd__,
   attribute,Expr,__rand__,
   attribute,Expr,__rmod__,
   attribute,Expr,__rmul__,
   attribute,Expr,__ror__,
   attribute,Expr,__rsub__,
   attribute,Expr,__rtruediv__,
   attribute,datafusion.expr,IsNull,
   attribute,datafusion.expr,Unnest,
   attribute,datafusion.expr,Window,
   attribute,datafusion.expr,__all__,
   attribute,datafusion.functions,__all__,
   attribute,datafusion,object_store,
   attribute,datafusion,runtime,
   attribute,datafusion,substrait,
   ```
   
   
   Code to generate:
   ```
   import datafusion
   
   def missing_exports(internal_obj, wrapped_obj):
       for attr in dir(internal_obj):
           if attr not in dir(wrapped_obj):
               print(f"attribute,{wrapped_obj.__name__},{attr},")
               continue
           internal_attr = getattr(internal_obj, attr)
           wrapped_attr = getattr(wrapped_obj, attr)
           if attr in ["__self__", "__class__"]:
               continue
           if isinstance(internal_attr, list):
               for val in internal_attr:
                   if val not in wrapped_attr:
                       print(f"value,{wrapped_obj.__name__},{attr},{val}")
           elif hasattr(internal_attr, '__dict__'):
               missing_exports(internal_attr, wrapped_attr)
   
   missing_exports(datafusion._internal, datafusion)
   ```
   
   I can work on adding these tomorrow morning and I can also add this code as 
a unit test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to