findepi commented on code in PR #11478:
URL: https://github.com/apache/datafusion/pull/11478#discussion_r1693318551
##########
datafusion/physical-plan/src/repartition/mod.rs:
##########
@@ -415,7 +415,7 @@ struct RepartitionMetrics {
/// Time in nanos to execute child operator and fetch batches
fetch_time: metrics::Time,
/// Time in nanos to perform repartitioning
- repartition_time: metrics::Time,
+ repart_time: metrics::Time,
Review Comment:
Yeah, i agree that consistency is really desirable. Therefore this PR is a
good change (I will approve).
I would prefer that we change the metric name though. Readable naming is as
valuable for code as it is for external metrics. I know it's a breaking change,
but I don't know of other way to improve the naming while avoiding the
breakage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
