alamb commented on issue #21231: URL: https://github.com/apache/datafusion/issues/21231#issuecomment-4389149703
> This approach also aligns perfectly with the collect/project idea I sketched above. Would we still want to introduce methods on PhsyicalExpr to support this? We would essentially be replacing the current downcasting code with polymorphic method calls which could support custom column expressions provide we accept the 'extend/append only' model. In my opinion, the general idea of switching to methods on PhysicalExpr rather than downcasting is a good idea in general as it makes the code easier to reason about and the contracts of what PhysicalExprs do / are used for more explicit in the trait (rather than having to look through the codebase at the uses) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
