Geethapranay1 commented on issue #4131: URL: https://github.com/apache/datafusion-comet/issues/4131#issuecomment-4386693229
Hi @comphead I checked the native path after your pr #4003 the fallback in operators.scala prevents incorrect results. The root cause comes from the native side that is comet builds FirstValue and LastValue without ordering at planner.rs, datafusion defaults to trivial accumulators and their merge behavior relies on position under MergeAsPartial. Is your goal to remove the fallback and support FIRST and LAST natively in PartialMerge? I will look into the implementation if you approve -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
