bvolpato commented on PR #20993: URL: https://github.com/apache/datafusion/pull/20993#issuecomment-4378215239
[review-prs-verification] Head: 38bb1d9812ae445bbbc5745f2d86988997cce6f2 Ready to merge: yes Files reviewed. - datafusion/substrait/src/logical_plan/consumer/rel/read_rel.rs - datafusion/substrait/tests/utils.rs - datafusion/substrait/tests/cases/aggregation_tests.rs - datafusion/substrait/tests/cases/consumer_integration.rs - datafusion/substrait/tests/cases/emit_kind_tests.rs - datafusion/substrait/tests/cases/logical_plans.rs - datafusion/substrait/tests/cases/roundtrip_logical_plan.rs - datafusion/substrait/tests/cases/serialize.rs - datafusion/substrait/tests/cases/substrait_validations.rs Tests/checks run and results. - Local: cargo test -p datafusion-substrait --tests --features protoc (pass) - Local: cargo fmt --all -- --check (pass) - Local: cargo check -p datafusion-substrait --tests --features protoc (pass) - Local: cargo clippy -p datafusion-substrait --tests --features protoc -- -D warnings (pass) - Local: cargo build -p datafusion-substrait --features protoc (pass) - CI: gh pr checks 20993 --repo apache/datafusion (all checks pass) Fixes committed/pushed, if any. - 38bb1d981 fix(substrait): preserve NamedTable arity when normalizing - aee5fcb4f test(substrait): refresh snapshots for normalized table refs - ffb593faf fix(substrait): normalize table names from Substrait NamedTable for Calcite interop Final CI status. - PASS: 35/35 checks passing on head 38bb1d9812ae445bbbc5745f2d86988997cce6f2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
