alamb commented on PR #11636: URL: https://github.com/apache/datafusion/pull/11636#issuecomment-2248671711
> Unless you think that rebase or squash makes the review easier, I don't think you need to do it. We don't have any rules requiring you to do so. Agreed -- the final merge into main is done with squash (so the entire PR turns into a single commit). I typically find it easier to review PRs where subsequent changes are made with new commits (rather than rebases) so it is more clear what changed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
