Omega359 commented on PR #21707: URL: https://github.com/apache/datafusion/pull/21707#issuecomment-4293186294
> My one blocking concern with this is the env vars. I think we should be able to / only support setting them via `DATAFUSION_EXECUTION_TARGET_PARTITIONS=1 cargo bench ...` and such. In general I agree however I wanted to make the migration as seamless as possible for people that might have scripting in place already when we start to remove the rust implementations of the migrated benchmarks. I figure it's something that can easily be handled in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
