alamb commented on issue #11360: URL: https://github.com/apache/datafusion/issues/11360#issuecomment-2243812261
> What is the rationale of single distinct to group by? Take count for example, I think distinct accumulator could be way more efficient than normal accumulator with group by 🤔 Before we had specialized and optimized accumulators (e.g the groups accumulators) I think the hash group by was more efficient than using special aggregators. Now that we have special accumulators for distinct aggregates, it may not be needed. we could run some benchmarks to check It also lets you do stuff like reuse the grouping if the same argument is shared between accumlators (`min(distinct x)` and `max(distinct x)` can be rewritten to deduplicate `x` once -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
