ozankabak commented on code in PR #11506:
URL: https://github.com/apache/datafusion/pull/11506#discussion_r1687123288
##########
datafusion/physical-plan/src/union.rs:
##########
@@ -99,7 +99,12 @@ impl UnionExec {
/// Create a new UnionExec
pub fn new(inputs: Vec<Arc<dyn ExecutionPlan>>) -> Self {
let schema = union_schema(&inputs);
- let cache = Self::compute_properties(&inputs, schema);
+ // The schema of the inputs and the union schema is consistent when:
+ // - They have the same number of fields, and
+ // - Their fields have same types at the same indices.
+ // Here, we know that schemas are consistent and the call below can
+ // not return an error.
+ let cache = Self::compute_properties(&inputs, schema).unwrap();
Review Comment:
I think it may be reasonable to return an `internal_err` as that would imply
something that is not supposed to happen has happened. Let's think a little
about doing that vs. panicking and do it in a follow-on PR if we decide to do so
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
