neilconway commented on code in PR #21240:
URL: https://github.com/apache/datafusion/pull/21240#discussion_r3081740560
##########
datafusion/sqllogictest/test_files/subquery.slt:
##########
@@ -1672,6 +1726,197 @@ drop table employees;
statement count 0
drop table project_assignments;
+#############
Review Comment:
Running the newly added test queries against `main`, there are the following
differences:
- `SELECT (SELECT v FROM pr_sq_values);` succeeds on main; with this PR,
it errors with "Scalar subquery returned more than one row."
- `SELECT x FROM pr_sq_main WHERE x > (SELECT v FROM pr_sq_values);` has
the same behavior change.
- `SELECT (SELECT v FROM pr_sq_empty);` returns zero rows on main; this
branch returns a single NULL.
In all cases, the old behavior was incorrect and the new behavior is
correct. This (and variations thereof) should be the main behavioral change
introduced in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
