alamb commented on PR #21260: URL: https://github.com/apache/datafusion/pull/21260#issuecomment-4201251616
> Good news on step 3 — the Omega359 fork features were already upstreamed to risinglightdb/sqllogictest-rs in v0.24.0 ([PR #237](https://github.com/risinglightdb/sqllogictest-rs/pull/237)), and DataFusion is already on v0.29.1. So no new fork needed, we just need to remove the fork swap from regenerate_sqlite_files.sh (line 167). Awesome! > The regenerate/sqllogictests.rs also needs updating (the non-postgres complete path is commented out), but that can be a separate follow-up. > > I'll get the datafusion-testing PR up next. Want me to include the script cleanup in the datafusion PR or keep it separate? If possible, can you make PRs: 1. A PR to update the scritps 2. A PR to update the expected tests in datafusion-testing Then we can update this PR with an updated pin of datafusion-testing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
