coderfender commented on code in PR #21366:
URL: https://github.com/apache/datafusion/pull/21366#discussion_r3042859989
##########
datafusion/functions/src/unicode/substr.rs:
##########
@@ -275,7 +275,7 @@ fn string_view_substr(
let start_array = as_int64_array(&args[0])?;
let count_array_opt = args.get(1).map(|a| as_int64_array(a)).transpose()?;
- let enable_ascii_fast_path =
+ let is_ascii =
enable_ascii_fast_path(&string_view_array, start_array,
count_array_opt);
Review Comment:
this is nice improvement to optimize ascii usecases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
