kazuyukitanimura commented on code in PR #3884:
URL: https://github.com/apache/datafusion-comet/pull/3884#discussion_r3040594260
##########
native/core/src/execution/planner.rs:
##########
@@ -406,7 +406,12 @@ impl PhysicalPlanner {
Ok(Arc::new(Cast::new(
child,
datatype,
- SparkCastOptions::new(eval_mode, &expr.timezone,
expr.allow_incompat),
+ {
+ let mut opts =
+ SparkCastOptions::new(eval_mode, &expr.timezone,
expr.allow_incompat);
+ opts.is_spark4_plus = expr.is_spark4_plus;
+ opts
+ },
Review Comment:
Not a blocker, but what about creating a new method, something like
`new_with_version()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
