dharanad commented on code in PR #11487:
URL: https://github.com/apache/datafusion/pull/11487#discussion_r1685399576
##########
datafusion/core/tests/optimizer_integration.rs:
##########
@@ -115,6 +117,139 @@ fn concat_ws_literals() -> Result<()> {
Ok(())
}
+#[test]
+fn anti_join_with_join_filter() -> Result<()> {
Review Comment:
For the earlier implementation, I also moved plannig of basic SQL like
column references to expr planner, we had to move these test cases from
`optimizer` crate to `core` to avoid `optimizer` crate dependecy on
`functions`.
Since we have moved that out of planner, ideally i should moved the
testcases back. My bad, i missed them. Thanks for catching this. I have fixed
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
