viirya commented on code in PR #682:
URL: https://github.com/apache/datafusion-comet/pull/682#discussion_r1683563194
##########
common/src/main/java/org/apache/comet/vector/CometVector.java:
##########
@@ -79,14 +79,23 @@ public Decimal getDecimal(int i, int precision, int scale) {
} else {
byte[] bytes = getBinaryDecimal(i);
BigInteger bigInteger = new BigInteger(bytes);
- BigDecimal javaDecimal = new BigDecimal(bigInteger, scale);
Review Comment:
I have not run the microbenchmark yet but just looked at the Decimal.apply
and thought this might be helpful. Currently I also wonder why it fails
(overflow) on converting an integer 12345 to Decimal of precision 5 and scale 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
