parthchandra commented on code in PR #682:
URL: https://github.com/apache/datafusion-comet/pull/682#discussion_r1683542512
##########
common/src/main/java/org/apache/comet/vector/CometVector.java:
##########
@@ -79,14 +79,23 @@ public Decimal getDecimal(int i, int precision, int scale) {
} else {
byte[] bytes = getBinaryDecimal(i);
BigInteger bigInteger = new BigInteger(bytes);
- BigDecimal javaDecimal = new BigDecimal(bigInteger, scale);
Review Comment:
True.
Looks like Decimal.apply(BigInteger) has a fairly expensive check to see how
many bits are in use and see of the value will fit into an integer/long but it
might be worthy it downstream.
Are you able to see a difference in the micro benchmark with useDecimal128
enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
