alamb commented on code in PR #20421:
URL: https://github.com/apache/datafusion/pull/20421#discussion_r2984167461
##########
datafusion/sql/src/expr/function.rs:
##########
@@ -867,6 +905,7 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
Ok((exprs, names))
}
+ #[expect(dead_code)]
Review Comment:
> Would you expect inline ORDER BY to be supported only for quantile_cont
(and similar ordered-set aggregates), or should this be extended more generally
to other aggregate functions as well?
I am not sure -- I basically expect that datafusion would follow other
implementations rather than creating our own syntax. In the case where previous
versions of DataFusion supported syntax that is not supported by other systems,
I would expect that syntax to keep working, though we don't have to extend it
to other functions that didn't previously support it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
