parthchandra commented on PR #3730: URL: https://github.com/apache/datafusion-comet/pull/3730#issuecomment-4119800087
> Thanks @parthchandra. Could you run `CometCastStringToTemporalBenchmark`
before and after these changes so we can see performance impact?
benchmark after latest changes -
| Benchmark | Baseline (ms) | PR3730 (ms) | Change |
|---|---|---|---|
| Cast String to Date | 71 | 68 | 4% faster |
| Try_Cast String to Date | 70 | 66 | 6% faster |
| Cast String to Timestamp | 161 | 158 | 2% faster |
| Try_Cast String to Timestamp | 162 | 164 | 1% slower |
Essentially unchanged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
