andygrove commented on code in PR #3746:
URL: https://github.com/apache/datafusion-comet/pull/3746#discussion_r2968129038
##########
spark/src/test/scala/org/apache/comet/CometTemporalExpressionSuite.scala:
##########
@@ -395,4 +395,93 @@ class CometTemporalExpressionSuite extends CometTestBase
with AdaptiveSparkPlanH
// Test null handling
checkSparkAnswerAndOperator("SELECT unix_date(NULL)")
}
+
+ test("days") {
Review Comment:
nit: there are many different tests within this one test function. I wonder
if it would make sense to split them out into separate tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
