andygrove commented on code in PR #3746:
URL: https://github.com/apache/datafusion-comet/pull/3746#discussion_r2968125840
##########
spark/src/test/scala/org/apache/comet/CometTemporalExpressionSuite.scala:
##########
@@ -395,4 +395,93 @@ class CometTemporalExpressionSuite extends CometTestBase
with AdaptiveSparkPlanH
// Test null handling
checkSparkAnswerAndOperator("SELECT unix_date(NULL)")
}
+
+ test("days") {
+ import org.apache.spark.sql.Column
+ import org.apache.spark.sql.DataFrame
+ import org.apache.spark.sql.catalyst.expressions.{Days, Literal}
+ import org.apache.spark.sql.functions.col
Review Comment:
nit: it is unusual to have imports within the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
