buraksenn commented on code in PR #21073:
URL: https://github.com/apache/datafusion/pull/21073#discussion_r2967376684
##########
datafusion/core/benches/topk_aggregate.rs:
##########
@@ -290,152 +290,107 @@ fn criterion_benchmark(c: &mut Criterion) {
let limit = LIMIT;
let partitions = 10;
let samples = 1_000_000;
+ let total_rows = partitions * samples;
+
+ // Numeric aggregate benchmarks
+ // (asc, use_topk, use_view, run_asc)
+ let numeric_cases: &[(bool, bool, bool, bool, &str)] = &[
+ (
+ false,
+ false,
+ false,
+ false,
+ "aggregate {rows} time-series rows",
+ ),
+ (true, false, false, true, "aggregate {rows} worst-case rows"),
+ (
+ false,
+ true,
+ false,
+ false,
+ "top k={limit} aggregate {rows} time-series rows",
+ ),
+ (
+ true,
+ true,
+ false,
+ true,
+ "top k={limit} aggregate {rows} worst-case rows",
+ ),
+ (
+ false,
+ true,
+ true,
+ false,
+ "top k={limit} aggregate {rows} time-series rows [Utf8View]",
+ ),
+ (
+ true,
+ true,
+ true,
+ true,
+ "top k={limit} aggregate {rows} worst-case rows [Utf8View]",
+ ),
+ ];
+ for &(asc, use_topk, use_view, run_asc, name_tpl) in numeric_cases {
Review Comment:
Makes sense, I've got rid of `run_asc` and reordered cases. I can also
introduce a struct if requested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
