andygrove opened a new pull request, #3740: URL: https://github.com/apache/datafusion-comet/pull/3740
## Which issue does this PR close? Closes #. ## Rationale for this change The mutable buffer code path (`BatchReader`, `ConstantColumnReader`, `RowIndexColumnReader`, `MetadataColumnReader`) was only used by the iceberg-java integration which is no longer supported. The main scan path (`NativeBatchReader`) uses immutable Arrow Java vectors via `ArrowConstantColumnReader` and `ArrowRowIndexColumnReader` instead. This dead code can be safely removed. ## What changes are included in this PR? - Delete `BatchReader.java`, `IcebergCometBatchReader.java`, `ConstantColumnReader.java`, `RowIndexColumnReader.java`, `MetadataColumnReader.java` - Remove 13 JNI method declarations from `Native.java` (`setNull`, `setBoolean`, `setByte`, `setShort`, `setInt`, `setLong`, `setFloat`, `setDouble`, `setBinary`, `setDecimal`, `setPosition`, `setIndices`, `setIsDeleted`) - Remove corresponding Rust JNI implementations and `set_*` methods from the column reader - Remove `hasScanUsingMutableBuffers` check in `EliminateRedundantTransitions` since no scan path uses mutable buffers anymore - Remove unused `DECIMAL_BYTE_WIDTH` constant and `is_const` field - Clean up stale comments and unused imports - Preserve `testIsFixedLength` test from `TestColumnReader` **-1,476 lines** of dead code removed. ## How are these changes tested? - Native code passes `cargo clippy --all-targets --workspace -- -D warnings` - JVM code compiles cleanly with `mvn compile` - The removed code paths were only reachable from `IcebergCometBatchReader` (deleted) and `TestColumnReader` mutable buffer tests (deleted). The `testIsFixedLength` test is preserved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
