coderfender commented on code in PR #2897:
URL: https://github.com/apache/datafusion-comet/pull/2897#discussion_r2961368402
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1266,6 +1266,30 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("cast ArrayType to ArrayType") {
+ val types = Seq(
+ BooleanType,
+ StringType,
+ ByteType,
+ IntegerType,
+ LongType,
+ ShortType,
+ DecimalType(10, 2),
+ DecimalType(38, 18))
+ for (fromType <- types) {
+ for (toType <- types) {
+ if (fromType != toType &&
+ !tags
Review Comment:
Should we check if we can cast `fromt_type` to `to_type` before proceeding
with the cast itself ?
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -1266,6 +1266,30 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
}
+ test("cast ArrayType to ArrayType") {
+ val types = Seq(
+ BooleanType,
+ StringType,
+ ByteType,
+ IntegerType,
+ LongType,
+ ShortType,
+ DecimalType(10, 2),
+ DecimalType(38, 18))
+ for (fromType <- types) {
+ for (toType <- types) {
+ if (fromType != toType &&
+ !tags
Review Comment:
Should we check if we can cast `from_type` to `to_type` before proceeding
with the cast itself ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
