kosiew commented on code in PR #1420:
URL:
https://github.com/apache/datafusion-python/pull/1420#discussion_r2929709858
##########
python/datafusion/functions.py:
##########
@@ -1352,6 +1362,14 @@ def make_list(*args: Expr) -> Expr:
"""Returns an array using the specified input expressions.
This is an alias for :py:func:`make_array`.
Review Comment:
The alias functions now duplicate a lot of near-identical doctest text. For
cases like `make_list`/`array` and the various `list_*` or `array_*` aliases,
consider keeping the runnable example on the canonical function and letting
alias docstrings point back to it. That would keep this module smaller and make
future example edits less repetitive.
##########
python/datafusion/functions.py:
##########
@@ -2013,6 +2689,14 @@ def array_agg(
For example::
df.aggregate([], array_agg(col("a"), order_by="b"))
Review Comment:
`array_agg` is an aggregate function rather than a scalar array/list helper,
so its new example feels a little outside the stated scope of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
