CuteChuanChuan commented on code in PR #20807:
URL: https://github.com/apache/datafusion/pull/20807#discussion_r2919401155
##########
datafusion/physical-expr-common/src/binary_view_map.rs:
##########
@@ -351,13 +348,16 @@ where
payload
} else {
// no existing value, make a new one
- let payload = make_payload_fn(Some(input_value));
- let new_view = if is_inline {
+ let (payload, new_view) = if is_inline {
+ // Extract inline bytes from view (only for new values)
+ let view_bytes = view_u128.to_le_bytes();
+ let payload = make_payload_fn(Some(&view_bytes[4..4 + len
as usize]));
Review Comment:
Removed the parameter from `make_payload_fn`; updated callers and test
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
