vigneshsiva11 commented on PR #3278:
URL:
https://github.com/apache/datafusion-comet/pull/3278#issuecomment-4038058673
hi @codecov-commenter, @andygrove I've addressed the review comments:
**Changes made:**
1. **Added `aliases()` method** - The `SparkDateDiff` implementation now
properly exposes the `"datediff"` alias by implementing the `aliases()` method.
This resolves the unused field warning.
2. **Improved regression test**—Updated the test to use
`checkSparkAnswerAndOperator()` instead of a simple assertion. This now
validates both:
- Result correctness (matches Spark's behavior)
- Query plan verification (ensures Comet native execution is used)
3. **Fixed test reproducibility**—Replaced `current_date()` with a fixed
date literal (`date '2024-01-10'`) to make the test deterministic and
reproducible.
All changes have been pushed and CI checks should run cleanly now. Happy to
make any additional adjustments if needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
