2010YOUY01 commented on code in PR #20810: URL: https://github.com/apache/datafusion/pull/20810#discussion_r2917233492
########## datafusion/sqllogictest/test_files/joins.slt: ########## @@ -5056,6 +5056,48 @@ LEFT ANTI JOIN t2 ON k1 = k2 WHERE k1 < 0 ---- +# Also check that the reported number of output rows/batches are correct in the "empty build side" +# optimization. Review Comment: ```suggestion # optimization. # Issue: https://github.com/apache/datafusion/issues/20809 ``` For future reference if the join order changed. Unfortunately we don't have a configuration to turn off the join reordering, so this test case might need some maintenance in the future. ########## datafusion/physical-plan/src/joins/hash_join/stream.rs: ########## @@ -655,10 +655,10 @@ impl HashJoinStream { self.join_type, )?; timer.done(); Review Comment: Not related to this PR, but I noticed we don’t need to explicitly end the timer here since it’s an RAII variable. I’ll open a separate PR after this is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
