erenavsarogullari commented on code in PR #20816: URL: https://github.com/apache/datafusion/pull/20816#discussion_r2915787244
########## datafusion/sqllogictest/test_files/set_variable.slt: ########## @@ -450,3 +450,9 @@ datafusion.runtime.temp_directory statement error DataFusion error: Error during planning: Unsupported value Null SET datafusion.runtime.memory_limit = NULL + +statement error DataFusion error: Error during planning: Unsupported value Null +SET datafusion.runtime.list_files_cache_ttl = NULL + +statement error DataFusion error: Error during planning: Duration should not be empty or blank for 'datafusion.runtime.list_files_cache_ttl' +SET datafusion.runtime.list_files_cache_ttl = ' ' Review Comment: All invalid durations are being tested by [test_parse_duration(https://github.com/apache/datafusion/pull/20816/changes#diff-ea1df26aafe37d2465b4a63a6460a3ea1757e0f5b16de7964dc48b96ba8ab27aR2830) This test case have also verified `error message` here as additional test coverage to `test_parse_duration`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
