asolimando commented on PR #19957: URL: https://github.com/apache/datafusion/pull/19957#issuecomment-4032216072
Rebased on latest `main` to fix the branch drift. No code changes, just new SHAs from the rebase. @gene-bordegaray: the code you reviewed is unchanged. The only addition since your approval is commit [`e352c28`](https://github.com/apache/datafusion/pull/19957/commits/e352c2839), which updates test expectations in `test_hash_join_partition_statistics` (added by [#20711](https://github.com/apache/datafusion/pull/20711)) to account for NDV propagation through merges. No new logic was added. @jonathanc-n: as you suggested, the `ExpressionAnalyzer` commits have been removed from this PR and will come in a [follow-up](https://github.com/asolimando/datafusion/tree/asolimando/ndv-expression-analyzer). @xudong963: I replied to your [comments on NDV merge strategy](https://github.com/apache/datafusion/pull/19957#discussion_r2897501498), let me know if you have further concerns or if we should take the discussion to an RFC/issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
