CuteChuanChuan commented on PR #20498: URL: https://github.com/apache/datafusion/pull/20498#issuecomment-4025127060
Addressed review comments: - Added all-null mask fast path - Replaced ArrayDataBuilder with safe constructors (PrimitiveArray, BooleanArray, FixedSizeBinaryArray) and added SAFETY comments on remaining unsafe blocks - Replaced raw ArrayData manipulation with DictionaryArray::new in scatter_dict - Restored removed comments - Added scatter_fixed_size_binary_test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
