mjbshaw commented on code in PR #2273:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2273#discussion_r2906197873
##########
src/ast/mod.rs:
##########
@@ -4624,6 +4624,19 @@ pub enum Statement {
is_eq: bool,
},
/// ```sql
+ /// LOCK [ TABLE ] [ ONLY ] name [ * ] [, ...] [ IN lockmode MODE ] [
NOWAIT ]
+ /// ```
+ ///
+ /// Note: this is a PostgreSQL-specific statement. See
<https://www.postgresql.org/docs/current/sql-lock.html>
+ Lock {
Review Comment:
I pulled this out to a separate struct, but I kept it named as `Lock`
because Postgres defines the statement as `LOCK [ TABLE ] ...`, so `TABLE` is
optional and the statement itself is `LOCK`. That seems to match existing
naming here like `Analyze` and `Truncate`, where an optional `TABLE` keyword is
represented in the data instead of the type name. I can change it if you really
want but `Lock` seems the most consistent to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
