LucaCappelletti94 commented on code in PR #2250:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2250#discussion_r2884641125
##########
src/parser/mod.rs:
##########
@@ -5100,7 +5100,14 @@ impl<'a> Parser<'a> {
let persistent = dialect_of!(self is DuckDbDialect)
&& self.parse_one_of_keywords(&[Keyword::PERSISTENT]).is_some();
let create_view_params = self.parse_create_view_params()?;
- if self.parse_keyword(Keyword::TABLE) {
+ if self.parse_keywords(&[Keyword::TEXT, Keyword::SEARCH]) {
+ if or_replace || or_alter || temporary || global.is_some() ||
transient || persistent {
+ return Err(ParserError::ParserError(
+ "CREATE TEXT SEARCH does not support CREATE
modifiers".to_string(),
+ ));
+ }
Review Comment:
Well this is not semantics, it would be constructing a syntax tree that is
not currently valid syntax in any of the supported dialects. I have already
encountered this genre of issue a few times and I am a bit confused as to which
direction should be preferable.
You would prefer going for the permissive route?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
