comphead commented on code in PR #11218:
URL: https://github.com/apache/datafusion/pull/11218#discussion_r1678511553
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -577,6 +595,8 @@ struct BufferedBatch {
/// The indices of buffered batch that failed the join filter.
/// When dequeuing the buffered batch, we need to produce null joined rows
for these indices.
pub join_filter_failed_idxs: HashSet<u64>,
+ pub num_rows: usize,
Review Comment:
documented newly added struct fields and null_joined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
