kevinjqliu commented on issue #1395: URL: https://github.com/apache/datafusion-python/issues/1395#issuecomment-3961328526
Great idea! I was wondering why these functions were not available for import For iceberg-rust, when upgrading to datafusion 52.x, we copied over the definition for `validate_pycapsule` and `ffi_logical_codec_from_pycapsule` https://github.com/apache/iceberg-rust/pull/1997/files#diff-1a7b28a196f60421838fd52ca356647a835081dc3095f1b55d526c27580cb677R34-R66 Would be great to be able to import those directly instead of copy/pasting. I see `ffi_logical_codec_from_pycapsule` is only defined in `examples/datafusion-ffi-example/src/utils.rs` and `docs/source/user-guide/upgrade-guides.rst`. <img width="1007" height="349" alt="Image" src="https://github.com/user-attachments/assets/6c8de0f2-8a40-4b2e-aac9-cc14268b4ea0"; /> Would be a good first candidate to copy over -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
