andygrove opened a new pull request, #3597: URL: https://github.com/apache/datafusion-comet/pull/3597
## Summary - Add `--jfr` and `--jfr-dir` flags to `run.py` that enable JFR profiling for both Spark driver and executors - JFR options are appended to `spark.driver.extraJavaOptions` / `spark.executor.extraJavaOptions`, preserving any existing values from engine configs - No Docker Compose or Dockerfile changes needed — JFR is built into JDK 11+ and the `/results` volume is already shared across all containers - JFR recordings land in `$RESULTS_DIR/jfr/` on the host for analysis with JDK Mission Control, IntelliJ, or `jfr` CLI ## Test plan - [ ] Run `python3 run.py --engine comet --benchmark tpch --jfr --dry-run` and verify `extraJavaOptions` contain JFR flags - [ ] Run a benchmark with `--jfr` in Docker Compose and verify `.jfr` files appear in `$RESULTS_DIR/jfr/` - [ ] Verify JFR files can be opened in JDK Mission Control 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
