erenavsarogullari commented on code in PR #20484:
URL: https://github.com/apache/datafusion/pull/20484#discussion_r2844751341
##########
datafusion/sqllogictest/test_files/spark/array/shuffle.slt:
##########
@@ -107,6 +107,12 @@ SELECT shuffle([1, 2, 3, 4], CAST('2' AS INT));
----
[1, 4, 2, 3]
+query error DataFusion error: Execution error: shuffle seed must be Int64 type
but got 'NULL'
+SELECT shuffle([1, 2, 3], NULL);
Review Comment:
Yes, we need to support Spark behavior here instead of returning error
message so i have just fixed legacy behavior and updated UT cases to return
deterministic result in order to avoid flakiness because when seed is NULL,
shuffle result will be non-deterministic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
