Jefffrey commented on code in PR #20484:
URL: https://github.com/apache/datafusion/pull/20484#discussion_r2838773409
##########
datafusion/sqllogictest/test_files/spark/array/shuffle.slt:
##########
@@ -107,6 +107,12 @@ SELECT shuffle([1, 2, 3, 4], CAST('2' AS INT));
----
[1, 4, 2, 3]
+query error DataFusion error: Execution error: shuffle seed must be Int64 type
but got 'NULL'
+SELECT shuffle([1, 2, 3], NULL);
Review Comment:
This doesn't actually seem to match spark semantics
```python
>>> spark.sql("select shuffle(array(1,2,3), null)").show()
+-----------------------+
|shuffle(array(1, 2, 3))|
+-----------------------+
| [1, 2, 3]|
+-----------------------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
