andygrove opened a new pull request, #20480: URL: https://github.com/apache/datafusion/pull/20480
## Summary - Fix silent error swallowing in `fetch_right_columns_from_batch_by_idxs` spill path where `vec.extend(take(...))` silently dropped errors (since `Result<T>` implements `IntoIterator`, yielding 0 items on `Err`) - Replace with `vec.push(take(...)?)` to properly propagate errors - Fix incorrect `Vec::with_capacity(buffered_indices.len())` which pre-allocated based on row count instead of column count - Add unit test verifying spill path produces identical results to in-memory path ## Test plan - [x] `cargo test -p datafusion-physical-plan sort_merge_join` — all 49 tests pass - [x] `cargo clippy -p datafusion-physical-plan -- -D warnings` — clean - [x] New `spill_path_matches_in_memory_path` test verifies column-for-column parity between spill and in-memory paths 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
