jayshrivastava commented on code in PR #20416:
URL: https://github.com/apache/datafusion/pull/20416#discussion_r2834559974
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -180,18 +291,52 @@ impl DynamicFilterPhysicalExpr {
}
}
+ /// Create a new [`DynamicFilterPhysicalExpr`] from `self`, except it
overwrites the
+ /// internal state with the source filter's state.
+ ///
+ /// This is a low-level API intended for use by the proto deserialization
layer.
+ ///
+ /// # Safety
+ ///
+ /// The dynamic filter should not be in use when calling this method,
otherwise there
+ /// may be undefined behavior. Changing the inner state of a filter may do
the following:
+ /// - transition the state to complete without notifying the watch
+ /// - cause a generation number to be emitted which is out of order
+ pub fn new_from_source(
+ self: &Arc<Self>,
+ source: &DynamicFilterPhysicalExpr,
+ ) -> Result<Self> {
+ // If there's any references to this filter or any watchers, we should
not replace the
+ // inner state.
+ if self.is_used() || self.state_watch.receiver_count() > 0 {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
